From 85aacf12e3d54e82da1405b0a88350130a886653 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fe=CC=81lix=20Pe=CC=81ault?= Date: Tue, 7 Jun 2022 14:54:28 +0200 Subject: [PATCH] Code optimizations --- src/components/Metas.svelte | 8 ++++---- src/components/organisms/Locations.svelte | 9 +++------ src/style/molecules/_heading.scss | 12 ++++++++---- src/style/pages/_explore.scss | 2 +- 4 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/components/Metas.svelte b/src/components/Metas.svelte index 4cbe6f8..2fa1dd3 100644 --- a/src/components/Metas.svelte +++ b/src/components/Metas.svelte @@ -1,11 +1,11 @@ diff --git a/src/components/organisms/Locations.svelte b/src/components/organisms/Locations.svelte index 3134585..f2888d5 100644 --- a/src/components/organisms/Locations.svelte +++ b/src/components/organisms/Locations.svelte @@ -9,12 +9,13 @@ import Button from '$components/atoms/Button.svelte' import Location from '$components/molecules/Location.svelte' - export let locations: any + export let locations: any[] const { continents, settings: { explore_list }} = getContext('global') // Continents filtering logic let currentContinent: string = undefined + $: filteredLocations = locations.filter(({ country: { continent }}: any) => { if (!currentContinent) { // Show all locations by default @@ -30,11 +31,7 @@ * Filter locations from continent */ const filterLocation = throttle((continent: string) => { - if (continent !== currentContinent) { - currentContinent = continent - } else { - currentContinent = undefined - } + currentContinent = continent !== currentContinent ? continent : null }, 700) diff --git a/src/style/molecules/_heading.scss b/src/style/molecules/_heading.scss index 5411fa7..5990b24 100644 --- a/src/style/molecules/_heading.scss +++ b/src/style/molecules/_heading.scss @@ -1,13 +1,17 @@ .heading { overflow: hidden; - color: $color-tertiary; text-align: center; + color: $color-tertiary; + + @include bp (sm) { + margin-bottom: 128px; + } // Title h1 { - color: $color-secondary; - line-height: 1; margin-top: 56px; + line-height: 1; + color: $color-secondary; @include bp (sm) { margin-top: 160px; @@ -20,8 +24,8 @@ font-weight: 200; @include bp (sm) { - margin: 72px auto 130px; max-width: 600px; + margin-top: 72px; } } } \ No newline at end of file diff --git a/src/style/pages/_explore.scss b/src/style/pages/_explore.scss index debfd1a..f87ec17 100644 --- a/src/style/pages/_explore.scss +++ b/src/style/pages/_explore.scss @@ -23,7 +23,7 @@ font-weight: 200; @include bp (sm) { - margin: 72px auto 130px; + margin: 72px auto 128px; max-width: 500px; } }